]> git.dujemihanovic.xyz Git - u-boot.git/commit
clk: sifive: fu540-prci: Change include order
authorJagan Teki <jagan@amarulasolutions.com>
Wed, 8 May 2019 14:22:18 +0000 (19:52 +0530)
committerJagan Teki <jagan@amarulasolutions.com>
Wed, 8 May 2019 19:13:59 +0000 (00:43 +0530)
commitdb2f6961477115045df6acf36667ede2644b934d
tree76ea6310b964237a6346b7c07e075a2cc38a67e2
parent0cbee8544b4e5282d20d6bc40c505c6fa0589773
clk: sifive: fu540-prci: Change include order

Like clk_get_by_index, there is requirement for
clk_get_by_index_nodev. In this case to make common
code functionalities for dev and nodev, clk_get_by_index
is trying to get the index of clock by passing ofnode
instead of actual dev like current gpio uclass does.

In these scenarios with current order of include files
the fu540-prci driver is unable to find CONFIG_ENV_SIZE.

In file included from arch/riscv/include/asm/u-boot.h:23:0,
                 from include/dm/of.h:10,
                 from include/dm/ofnode.h:12,
                 from include/clk.h:11,
                 from include/clk-uclass.h:13,
                 from drivers/clk/sifive/fu540-prci.c:32:
include/environment.h:145:19: error: 'CONFIG_ENV_SIZE'
undeclared here (not in a function); did you mean 'CONFIG_CMD_XIMG'?
 #define ENV_SIZE (CONFIG_ENV_SIZE - ENV_HEADER_SIZE)

So, fix consists of changing the order of include files
in fu540-prci.c to include first common.h file.

Cc: Anup Patel <Anup.Patel@wdc.com>
Cc: Rick Chen <rick@andestech.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
drivers/clk/sifive/fu540-prci.c