]> git.dujemihanovic.xyz Git - u-boot.git/commit
cli: Correct handling of invalid escape sequences in cread_line()
authorSimon Glass <sjg@chromium.org>
Mon, 27 Mar 2023 19:34:14 +0000 (08:34 +1300)
committerTom Rini <trini@konsulko.com>
Tue, 28 Mar 2023 13:25:51 +0000 (09:25 -0400)
commitbe0169f07e38b81dd96bca2e80610592d89f8550
tree09e08eefd123e358b5012df3dd88f233547b64d8
parent17b45e684af98c1cf37648ad05a98d500b367c5a
cli: Correct handling of invalid escape sequences in cread_line()

The second call to cli_ch_process() is in the wrong place, meaning that
the one of the characters of an invalid escape sequence is swallowed
instead of being returned.

Fix the bug and add a test to cover this.

This behaviour matches that of the code before cli_getch() was
introduced. This was verified on the commit before b08e9d4b66 i.e.:

   7d850f85aad ("sandbox: Enable mmc command and legacy images")

Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
common/cli_readline.c
include/cli.h
test/common/cread.c