]> git.dujemihanovic.xyz Git - u-boot.git/commit
serial: ns16550: Fix ordering of getting base address
authorBin Meng <bmeng.cn@gmail.com>
Sat, 4 Apr 2020 01:35:32 +0000 (18:35 -0700)
committerBin Meng <bmeng.cn@gmail.com>
Sat, 4 Apr 2020 14:08:44 +0000 (22:08 +0800)
commit9e6ce62190b7cd874d2bf727c7681292551ba6b9
tree5ab225f318936e07aa1db4d1de84a44a596f5276
parent4d073fa83bed62c65aeedb71c4b5584371dc59b7
serial: ns16550: Fix ordering of getting base address

Currently the driver gets ns16550 base address in the driver
probe() routine, which may potentially break any ns16550 wrapper
driver that does additional initialization before calling
ns16550_serial_probe().

Things are complicated that we need consider ns16550 devices on
both simple-bus and PCI bus. To fix the issue we move the base
address assignment for simple-bus ns16550 device back to the
ofdata_to_platdata(), and assign base address for PCI ns16550
device in ns16550_serial_probe().

This is still not perfect. If any PCI bus based ns16550 wrapper
driver tries to access plat->base before calling probe(), it is
still subject to break.

Fixes: 720f9e1fdb0c9 ("serial: ns16550: Move PCI access from ofdata_to_platdata() to probe()")
Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
Tested-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
drivers/serial/ns16550.c