]> git.dujemihanovic.xyz Git - u-boot.git/commit
sunxi: A64: fix default DRAM_ODT_EN symbol
authorAndre Przywara <andre.przywara@arm.com>
Mon, 13 Aug 2018 11:10:08 +0000 (16:40 +0530)
committerJagan Teki <jagan@amarulasolutions.com>
Mon, 13 Aug 2018 11:17:38 +0000 (16:47 +0530)
commit8094f0cb0ce9c61f1e2638ad75ce45a677fe3c4a
treed05c55d8db32a64b9d4443edf3f9e76ca8ba68bc
parent25b3d90b2cf4ab6c5407a458f23f1fc669b02ce6
sunxi: A64: fix default DRAM_ODT_EN symbol

"default" lines in Kconfig are processed in order, the first hit will
stop considering subsequent lines. In the case of the DRAM_ODT_EN symbol
that means that everything following the first two lines will never be
checked:
------------
config DRAM_ODT_EN
bool "sunxi dram odt enable"
default n if !MACH_SUN8I_A23
default y if MACH_SUN8I_A23
default y if MACH_SUN8I_R40
default y if MACH_SUN50I
------------

Assuming that the "default y" for the A64 and the R40 were a deliberate
choice, fix the Kconfig stanza to take this into account.
Also remove the now redundant lines from the respective defconfigs.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
[jagan: droped 'default n' on original change]
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Tested-by: Jagan Teki <jagan@amarulasolutions.com> # A64, R40
Tested-by: Chen-Yu Tsai <wens@csie.org> # A23
arch/arm/mach-sunxi/Kconfig
configs/Bananapi_M2_Ultra_defconfig
configs/amarula_a64_relic_defconfig
configs/bananapi_m2_berry_defconfig
configs/sopine_baseboard_defconfig