]> git.dujemihanovic.xyz Git - u-boot.git/commit
watchdog: gpio_wdt: use __udelay() to avoid recursion
authorRasmus Villemoes <rasmus.villemoes@prevas.dk>
Tue, 27 Sep 2022 07:45:44 +0000 (09:45 +0200)
committerStefan Roese <sr@denx.de>
Tue, 27 Sep 2022 10:25:40 +0000 (12:25 +0200)
commit51443c9a499989f698a2921e72156713fe1a6bc2
treef25cd671298b258cfdcc6e4d223388705feb1f1f
parentf117c54cc83e3c519883edb5a48062644d38c443
watchdog: gpio_wdt: use __udelay() to avoid recursion

The udelay() function in lib/time.c contains a WATCHDOG_RESET()
call. The only reason this doesn't lead to a catastrophic infinite
recursion is due to the rate-limiting in wdt-uclass.c:

if (time_after_eq(now, priv->next_reset)) {
priv->next_reset = now + priv->reset_period;
wdt_reset(dev);
}

But this would fall apart if ->next_reset was updated after calling the
device's reset method.

This is needlessly fragile, and it's easy enough to avoid that
recursion in the first place by just using __udelay() directly.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Reviewed-by: Stefan Roese <sr@denx.de>
drivers/watchdog/gpio_wdt.c