]> git.dujemihanovic.xyz Git - u-boot.git/commit
ARM: davinci: SPL: fix BSS initialization
authorSekhar Nori <nsekhar@ti.com>
Thu, 30 May 2019 13:34:55 +0000 (19:04 +0530)
committerTom Rini <trini@konsulko.com>
Wed, 5 Jun 2019 16:14:02 +0000 (12:14 -0400)
commit2a766db93810672b9e0f405a35de65bbdcdbaa77
tree0a6e5a6a15692db7e79ad293a8e61a0775bddea9
parent4fddaf2b7d4ab23ec829bb208c892789447779e0
ARM: davinci: SPL: fix BSS initialization

U-Boot README recommends initializing SDRAM in board_init_f(). DA850
was doing it as part of board_init_r() (through call to spl_board_init()
which calls arch_cpu_init() which calls da850_ddr_setup())

This worked fine till commit 15b8c7505819 ("davinci:
da850evm/omapl138-lcdk: Move BSS to SDRAM because SRAM is full") moved
BSS to SDRAM.

Functions like mmc_initialize() called in board_init_r() assume BSS is
available. Since SDRAM was not initialized when arch/arm/lib/crt0.S tried
to initialize BSS to 0, BSS is not initialized correctly.

Fix this by simply calling arch_cpu_init() from board_init_f(). Also move
preloader_console_init() there to help debug issues with board_init_r().

With this spl_board_init() is no longer needed, we remove it.

Tested using MMC/SD boot on OMAP-L138 LCDK board.

Tested-by: Adam Ford <aford173@gmail.com> #da850evm
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Tested-by: Peter Howard <phoward@gme.net.au> #omapl138_lcdk
arch/arm/mach-davinci/spl.c
configs/da850_am18xxevm_defconfig
configs/da850evm_defconfig
configs/da850evm_nand_defconfig
configs/omapl138_lcdk_defconfig