]> git.dujemihanovic.xyz Git - u-boot.git/commit
net: phy: dp83867: avoid error in dp83867_of_init() when PHY has no OF node
authorVladimir Oltean <vladimir.oltean@nxp.com>
Wed, 23 Feb 2022 13:20:55 +0000 (15:20 +0200)
committerRamon Fried <ramon@neureality.ai>
Sun, 10 Apr 2022 05:44:12 +0000 (08:44 +0300)
commit107b14e36eaafebdc28666a9d5fecdd4044a59e3
treec6ad2d93d0895cb10242485e03e46d746ebcd0b8
parent8221c52d88fbe84ca9692dc23827e21403c952e8
net: phy: dp83867: avoid error in dp83867_of_init() when PHY has no OF node

A DM_ETH driver may use phy_connect() towards a PHY address on an MDIO
bus which is not specified in the device tree, as evidenced by:

pfe_eth_probe
-> pfe_phy_configure
   -> phy_connect

When this happens, the PHY will have an invalid OF node.

The dp83867_config() method has extra initialization steps which are
bypassed when the PHY lacks an OF node, which is undesirable because it
will lead to broken networking. Allow the rest of the code to run.

Fixes: 085445ca4104 ("net: phy: ti: Allow the driver to be more configurable")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
drivers/net/phy/dp83867.c