]> git.dujemihanovic.xyz Git - u-boot.git/commit
Makefile: apply dynamic relocations for LLD
authorNick Desaulniers <ndesaulniers@google.com>
Mon, 26 Sep 2022 20:47:40 +0000 (20:47 +0000)
committerTom Rini <trini@konsulko.com>
Mon, 10 Oct 2022 22:01:23 +0000 (18:01 -0400)
commit0b943587d28763db7f277ba1c168d86b4dfca288
treed1aa23401ac2f2d000433ee87fdea260d134aadc
parent43b7dcdf343aefa4578532ab97931c4e3b334ad8
Makefile: apply dynamic relocations for LLD

It seems that for aarch64, unless we apply dynamic relocations to the
location being relocated, we fail to boot.

As Fangrui notes:
  For dynamic relocations using the RELA format (readelf -Wr), GNU ld
  sets the initial content to r_addend; ld.lld doesn't do that by
  default (needs --apply-dynamic-relocs).

Otherwise .rodata appears to be full of NUL-bytes before relocation,
causing crashes when trying to invoke the function pointers in
init_sequence_f from initcall_run_list().

Link: https://reviews.llvm.org/D42797
Suggested-by: Fangrui Song <maskray@google.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Alistair Delva <adelva@google.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Makefile