From 68fc0b877b5ddc93eb542ffa26dcf83e7e2860a8 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Sat, 16 Mar 2024 10:36:44 +0100 Subject: [PATCH] cmd: bootefi: error handling bootefi selftest If bootefi selftest is executed and a problem with the device-tree installation occurs, efi_install_fdt() writes sensible error messages. It never returns EFI_INVALID_PARAMETER. It neither makes sense to check for EFI_INVALID_PARAMETER nor to show the usage help for the bootefi command in this case. Fixes: 296faf4f7ef1 ("cmd: bootefi: re-organize do_bootefi()") Signed-off-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas --- cmd/bootefi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/cmd/bootefi.c b/cmd/bootefi.c index b509440cde..578dbb19a7 100644 --- a/cmd/bootefi.c +++ b/cmd/bootefi.c @@ -171,9 +171,7 @@ static int do_bootefi(struct cmd_tbl *cmdtp, int flag, int argc, } ret = efi_install_fdt(fdt); - if (ret == EFI_INVALID_PARAMETER) - return CMD_RET_USAGE; - else if (ret != EFI_SUCCESS) + if (ret != EFI_SUCCESS) return CMD_RET_FAILURE; return do_efi_selftest(); -- 2.39.5