From: Weijie Gao Date: Wed, 19 Jul 2023 09:16:02 +0000 (+0800) Subject: spi: mtk_spim: clear IRQ enable bits X-Git-Tag: v2025.01-rc5-pxa1908~903^2~41 X-Git-Url: http://git.dujemihanovic.xyz/img/static/gitweb.css?a=commitdiff_plain;h=b43512d0468a7e409fc2a8d5130d5a2efdee1b3f;p=u-boot.git spi: mtk_spim: clear IRQ enable bits In u-boot we don't use IRQ. Instead, we poll busy bit in SPI_STATUS. However these IRQ enable bits may be set in previous boot stage (BootROM). If we leave these bits not cleared, although u-boot has disabled IRQ and nothing will happen, the linux kernel may encounter panic during initializing the spim driver due to IRQ event happens before IRQ handler is properly setup. This patch clear IRQ bits to prevent this from happening. Signed-off-by: SkyLake.Huang Signed-off-by: Weijie Gao Reviewed-by: Jagan Teki --- diff --git a/drivers/spi/mtk_spim.c b/drivers/spi/mtk_spim.c index 3a742d160c..418e586b91 100644 --- a/drivers/spi/mtk_spim.c +++ b/drivers/spi/mtk_spim.c @@ -242,6 +242,9 @@ static int mtk_spim_hw_init(struct spi_slave *slave) reg_val &= ~SPI_CMD_SAMPLE_SEL; } + /* Disable interrupt enable for pause mode & normal mode */ + reg_val &= ~(SPI_CMD_PAUSE_IE | SPI_CMD_FINISH_IE); + /* disable dma mode */ reg_val &= ~(SPI_CMD_TX_DMA | SPI_CMD_RX_DMA);