From: Simon Glass Date: Wed, 30 Nov 2016 03:00:13 +0000 (-0700) Subject: spi: Add error checking for invalid bus widths X-Git-Url: http://git.dujemihanovic.xyz/img/static/gitweb.css?a=commitdiff_plain;h=1b7c28f5147144d7902d048ca90be58987899c25;p=u-boot.git spi: Add error checking for invalid bus widths At present an invalid bus width prints a message but does not return an error. This is the opposite of the correct behaviour. Adjust it to avoid code bloat in the common case, and avoid hard-to-debug failure in the uncommon case. Signed-off-by: Simon Glass Reviewed-by: Jagan Teki --- diff --git a/drivers/spi/spi-uclass.c b/drivers/spi/spi-uclass.c index f59a70173c..1ab5b75fa1 100644 --- a/drivers/spi/spi-uclass.c +++ b/drivers/spi/spi-uclass.c @@ -418,7 +418,7 @@ int spi_slave_ofdata_to_platdata(const void *blob, int node, mode |= SPI_TX_QUAD; break; default: - error("spi-tx-bus-width %d not supported\n", value); + warn_non_spl("spi-tx-bus-width %d not supported\n", value); break; } @@ -433,7 +433,7 @@ int spi_slave_ofdata_to_platdata(const void *blob, int node, mode |= SPI_RX_QUAD; break; default: - error("spi-rx-bus-width %d not supported\n", value); + warn_non_spl("spi-rx-bus-width %d not supported\n", value); break; }