checkpatch.pl: Request if() instead #ifdef

There is a lot of use of #ifdefs in U-Boot. In an effort reduce this,
suggest using the compile-time construct.

Signed-off-by: Simon Glass <sjg@chromium.org>

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index cf620c8614ab85170f25ba7a543699b38a6a8290..17d41825c5e186222a8f2be7c134beda10a4b4c5 100755 (executable)
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2261,6 +2261,12 @@ sub u_boot_line {
                WARN("CMD_TEST",
                     "Possible new command - make sure you add a test\n" . $herecurr);
        }
+
+       # use if instead of #if
+       if ($line =~ /^\+#if.*CONFIG.*/) {
+               WARN("PREFER_IF",
+                    "Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where possible\n" . $herecurr);
+       }
 }
 
 sub process {