]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
led: Mark device instance with DM_FLAG_PROBE_AFTER_BIND
authorMarek Vasut <marex@denx.de>
Fri, 22 Apr 2022 13:15:54 +0000 (15:15 +0200)
committerTom Rini <trini@konsulko.com>
Thu, 28 Apr 2022 13:26:43 +0000 (09:26 -0400)
Calling device_probe() from uclass .post_bind() callback has all kinds
of odd side-effects, e.g. device instances not being available just yet.
Make use of the DM_FLAG_PROBE_AFTER_BIND instead, mark device instances
which need to be probe()d in order to configure the LED default state
with this flag and let the DM core do the device_probe() at the right
time instead.

Fixes: 72675b063b6 ("led: Configure LED default-state on boot")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
Cc: Sean Anderson <seanga2@gmail.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Steven Lawrance <steven.lawrance@softathome.com>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Tested-by: Patrice Chotard <patrice.chotard@foss.st.com>
drivers/led/led-uclass.c

index 5d7bf40896b4d7e0e61737092d3a275fdd08638e..2ce72933b6c511643183d9ae8fcc06d5ac63a13e 100644 (file)
@@ -98,7 +98,9 @@ static int led_post_bind(struct udevice *dev)
         * In case the LED has default-state DT property, trigger
         * probe() to configure its default state during startup.
         */
-       return device_probe(dev);
+       dev_or_flags(dev, DM_FLAG_PROBE_AFTER_BIND);
+
+       return 0;
 }
 
 static int led_post_probe(struct udevice *dev)