]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
mips: dts: Fix PIC32MZDA GPIO register definitions
authorJohn Robertson <john.robertson@simiatec.com>
Tue, 1 Sep 2020 18:02:20 +0000 (18:02 +0000)
committerDaniel Schwierzeck <daniel.schwierzeck@gmail.com>
Tue, 22 Sep 2020 22:14:29 +0000 (00:14 +0200)
The GPIO bank name for banks J and K are not correct when using the
'gpio' command from the console.

The driver derives the bank name from the device tree instance string by
using the instance value and adding 'A': gpio0@xxaddrxx is Bank A,
gpio1@yyaddryy is Bank B and so on.

On the PIC32, there is no Bank I so instances 8 and 9 need to be
incremented as a minimum change.

An alternative (less opaque) implementation would be to use a bank-name
property instead but this would require modifying the driver code too.

Signed-off-by: John Robertson <john.robertson@simiatec.com>
arch/mips/dts/pic32mzda.dtsi

index cd156de848632102e0fbc6ad2fb4667f6c5b5ff2..43cd7cf3047b6e71fbbb9c7395382b63a464f04d 100644 (file)
                        #gpio-cells = <2>;
                };
 
-               gpioJ: gpio8@1f860800 {
+               gpioJ: gpio9@1f860800 {
                        compatible = "microchip,pic32mzda-gpio";
                        reg = <0x1f860800 0xe0>;
                        gpio-controller;
                        #gpio-cells = <2>;
                };
 
-               gpioK: gpio9@1f860900 {
+               gpioK: gpio10@1f860900 {
                        compatible = "microchip,pic32mzda-gpio";
                        reg = <0x1f860900 0xe0>;
                        gpio-controller;