]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
mxs: mxsboot: fix endianess for sd boot images
authorMichael Heimpold <mhei@heimpold.de>
Tue, 1 Sep 2015 21:58:44 +0000 (23:58 +0200)
committerStefano Babic <sbabic@denx.de>
Sun, 13 Sep 2015 08:19:40 +0000 (10:19 +0200)
Running mxsboot on a big-endian system produces a sd image which
cannot be started by the i.MX28 ROM. It complains on the debug
uart as following:
0x8020a009
          0x80502008
0x8020a009
          0x80502008
...

Enforcing all fields within the BCB to little-endian make
the image bootable again.

Signed-off-by: Michael Heimpold <mhei@heimpold.de>
Acked-by: Stefano Babic <sbabic@denx.de>
Acked-by: Marek Vasut <marex@denx.de>
tools/mxsboot.c

index 15eec9179d667ec7a3339a2f4034318fd4add0e4..3434c81792cbcb4827849c87a2f83acd22e8330d 100644 (file)
@@ -7,6 +7,7 @@
  * SPDX-License-Identifier:    GPL-2.0+
  */
 
+#include <endian.h>
 #include <fcntl.h>
 #include <sys/stat.h>
 #include <sys/types.h>
@@ -556,15 +557,15 @@ static int mx28_create_sd_image(int infd, int outfd)
 
        cb = (struct mx28_sd_config_block *)buf;
 
-       cb->signature = 0x00112233;
-       cb->primary_boot_tag = 0x1;
-       cb->secondary_boot_tag = 0x1;
-       cb->num_copies = 1;
-       cb->drv_info[0].chip_num = 0x0;
-       cb->drv_info[0].drive_type = 0x0;
-       cb->drv_info[0].tag = 0x1;
-       cb->drv_info[0].first_sector_number = sd_sector + 4;
-       cb->drv_info[0].sector_count = (size - 4) / 512;
+       cb->signature = htole32(0x00112233);
+       cb->primary_boot_tag = htole32(0x1);
+       cb->secondary_boot_tag = htole32(0x1);
+       cb->num_copies = htole32(1);
+       cb->drv_info[0].chip_num = htole32(0x0);
+       cb->drv_info[0].drive_type = htole32(0x0);
+       cb->drv_info[0].tag = htole32(0x1);
+       cb->drv_info[0].first_sector_number = htole32(sd_sector + 4);
+       cb->drv_info[0].sector_count = htole32((size - 4) / 512);
 
        wr_size = write(outfd, buf, size);
        if (wr_size != size) {