sandbox: check lseek return value in handle_ufi_command

Invoking lseek() may result in an error. Handle it.

Addresses-Coverity-ID: 376212 ("Error handling issues  (CHECKED_RETURN)")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

diff --git a/drivers/usb/emul/sandbox_flash.c b/drivers/usb/emul/sandbox_flash.c
index 6e8cfe1650a0524cea11f3ba621c37add72a624b..01ccc4bc178fffea7c2d94a392d037d5478bd4c0 100644 (file)
--- a/drivers/usb/emul/sandbox_flash.c
+++ b/drivers/usb/emul/sandbox_flash.c
@@ -188,15 +188,19 @@ static int handle_ufi_command(struct sandbox_flash_priv *priv, const void *buff,
        struct scsi_emul_info *info = &priv->eminfo;
        const struct scsi_cmd *req = buff;
        int ret;
+       off_t offset;
 
        ret = sb_scsi_emul_command(info, req, len);
        if (!ret) {
                setup_response(priv);
        } else if ((ret == SCSI_EMUL_DO_READ || ret == SCSI_EMUL_DO_WRITE) &&
                   priv->fd != -1) {
-               os_lseek(priv->fd, info->seek_block * info->block_size,
-                        OS_SEEK_SET);
-               setup_response(priv);
+               offset = os_lseek(priv->fd, info->seek_block * info->block_size,
+                                 OS_SEEK_SET);
+               if (offset == (off_t)-1)
+                       setup_fail_response(priv);
+               else
+                       setup_response(priv);
        } else {
                setup_fail_response(priv);
        }