]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
usb: dwc3: meson-gxl: switch to generic_phy_set_mode
authorNeil Armstrong <neil.armstrong@linaro.org>
Thu, 20 Jun 2024 07:42:51 +0000 (09:42 +0200)
committerNeil Armstrong <neil.armstrong@linaro.org>
Tue, 25 Jun 2024 13:25:10 +0000 (15:25 +0200)
Use the PHY set_mode call instead of calling directly in the
PHY shared function.

Reviewed-by: Marek Vasut <marex@denx.de>
Link: https://lore.kernel.org/r/20240620-u-boot-usb-gxl-phy-set-mode-v2-2-b81c027bc02c@linaro.org
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
drivers/usb/dwc3/dwc3-meson-gxl.c

index 3e693c5ff310ad5e7a513ff1849856117b26cf73..290ac03a3749016576923f92d17f2c03f323f6f2 100644 (file)
@@ -158,9 +158,9 @@ static int dwc3_meson_gxl_usb2_init(struct dwc3_meson_gxl *priv)
                if (!priv->phys[i].dev)
                        continue;
 
-               phy_meson_gxl_usb2_set_mode(&priv->phys[i],
-                               (i == USB2_OTG_PHY) ? USB_DR_MODE_PERIPHERAL
-                                                   : USB_DR_MODE_HOST);
+               generic_phy_set_mode(&priv->phys[i],
+                               (i == USB2_OTG_PHY) ? PHY_MODE_USB_DEVICE
+                                                   : PHY_MODE_USB_HOST, 0);
        }
 
        return 0;
@@ -224,7 +224,9 @@ int dwc3_meson_gxl_force_mode(struct udevice *dev, enum usb_dr_mode mode)
 #endif
        priv->otg_phy_mode = mode;
 
-       phy_meson_gxl_usb2_set_mode(&priv->phys[USB2_OTG_PHY], mode);
+       generic_phy_set_mode(&priv->phys[USB2_OTG_PHY],
+                            mode == USB_DR_MODE_PERIPHERAL ? PHY_MODE_USB_DEVICE
+                                                           : PHY_MODE_USB_HOST, 0);
 
        dwc3_meson_gxl_usb2_set_mode(priv, mode);
 
@@ -361,8 +363,9 @@ static int dwc3_meson_gxl_probe(struct udevice *dev)
        }
 
        if (priv->phys[USB2_OTG_PHY].dev)
-               phy_meson_gxl_usb2_set_mode(&priv->phys[USB2_OTG_PHY],
-                                           priv->otg_phy_mode);
+               generic_phy_set_mode(&priv->phys[USB2_OTG_PHY],
+                       priv->otg_phy_mode == USB_DR_MODE_PERIPHERAL ? PHY_MODE_USB_DEVICE
+                                                                    : PHY_MODE_USB_HOST, 0);
 
        dwc3_meson_gxl_usb2_set_mode(priv, priv->otg_phy_mode);