]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
usb: dwc2: fix possible alignment issues
authorSimon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Thu, 21 Nov 2019 21:15:23 +0000 (22:15 +0100)
committerMarek Vasut <marek.vasut+renesas@gmail.com>
Fri, 22 Nov 2019 00:25:40 +0000 (01:25 +0100)
Since upgrading to gcc9, warnings are issued:
"taking address of packed member of ‘...’ may result in an unaligned
pointer value"

Fix this by converting dwc2_fifo_read to use unaligned access since packed
structures may be on an unaligned address, depending on USB hardware.

Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c

index 7eb632d3b1417ba76e8a45d72df9bf21a2d5b243..dba221dad01c9a784452c110c3e132ac0a015f84 100644 (file)
@@ -731,7 +731,7 @@ static int write_fifo_ep0(struct dwc2_ep *ep, struct dwc2_request *req)
        return 0;
 }
 
-static int dwc2_fifo_read(struct dwc2_ep *ep, u32 *cp, int max)
+static int dwc2_fifo_read(struct dwc2_ep *ep, void *cp, int max)
 {
        invalidate_dcache_range((unsigned long)cp, (unsigned long)cp +
                                ROUND(max, CONFIG_SYS_CACHELINE_SIZE));
@@ -1285,7 +1285,7 @@ static void dwc2_ep0_setup(struct dwc2_udc *dev)
        nuke(ep, -EPROTO);
 
        /* read control req from fifo (8 bytes) */
-       dwc2_fifo_read(ep, (u32 *)usb_ctrl, 8);
+       dwc2_fifo_read(ep, usb_ctrl, 8);
 
        debug_cond(DEBUG_SETUP != 0,
                   "%s: bRequestType = 0x%x(%s), bRequest = 0x%x"