usb: dwc3: Use generic_phy_valid() helper

The documentation for struct phy state that "The content of the
structure is managed solely by the PHY API and PHY drivers".

Change to use the generic_phy_valid() helper to check if phy is valid.
Also remove setting phy->dev to NULL now that generic_phy_get_by_name()
properly initialize phy->dev to NULL.

Fixes: 142d50fbce7c ("usb: dwc3: Add support for usb3-phy PHY configuration")
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>

diff --git a/drivers/usb/dwc3/dwc3-generic.c b/drivers/usb/dwc3/dwc3-generic.c
index 7f0af05855abb9b7a22e63c8b536cecd121b32b3..3997b9dbff43fb70c4a109799c76e373381f8504 100644 (file)
--- a/drivers/usb/dwc3/dwc3-generic.c
+++ b/drivers/usb/dwc3/dwc3-generic.c
@@ -541,8 +541,6 @@ int dwc3_glue_probe(struct udevice *dev)
        } else if (ret != -ENOENT && ret != -ENODATA) {
                debug("could not get phy (err %d)\n", ret);
                return ret;
-       } else {
-               phy.dev = NULL;
        }
 
        glue->regs = dev_read_addr_size_index(dev, 0, &glue->size);
@@ -555,7 +553,7 @@ int dwc3_glue_probe(struct udevice *dev)
        if (ret)
                return ret;
 
-       if (phy.dev) {
+       if (generic_phy_valid(&phy)) {
                ret = generic_phy_power_on(&phy);
                if (ret)
                        return ret;