]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
mtd: spinand: Fix display of unknown raw ID
authorPatrice Chotard <patrice.chotard@foss.st.com>
Mon, 13 Feb 2023 17:30:04 +0000 (18:30 +0100)
committerDario Binacchi <dario.binacchi@amarulasolutions.com>
Mon, 27 Feb 2023 15:30:09 +0000 (16:30 +0100)
In case ID is not found in manufacturer table, the raw ID is
printed using %*phN format which is not supported by lib/vsprintf.c.
The information displayed doesn't reflect the raw ID return by the
unknown spi-nand.

Use %02x format instead, as done in spi-nor-core.c.

For example, before this patch:
  ERROR: spi-nand: spi_nand flash@0: unknown raw ID f74ec040
after
  ERROR: spi-nand: spi_nand flash@0: unknown raw ID 00 c2 26 03

Fixes: 0a6d6bae0386 ("mtd: nand: Add core infrastructure to support SPI NANDs")
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Acked-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
drivers/mtd/nand/spi/core.c

index 134bf22c80553977bf71cebaf413201c5c8cdc73..70d8ae531eeb1807c87d5c15bbbb22212f20d1b2 100644 (file)
@@ -979,8 +979,9 @@ static int spinand_detect(struct spinand_device *spinand)
 
        ret = spinand_manufacturer_detect(spinand);
        if (ret) {
-               dev_err(spinand->slave->dev, "unknown raw ID %*phN\n",
-                       SPINAND_MAX_ID_LEN, spinand->id.data);
+               dev_err(spinand->slave->dev, "unknown raw ID %02x %02x %02x %02x\n",
+                       spinand->id.data[0], spinand->id.data[1],
+                       spinand->id.data[2], spinand->id.data[3]);
                return ret;
        }