]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
tools: kwboot: Fix wrong parameter passed to read()
authorPali Rohár <pali@kernel.org>
Fri, 23 Jul 2021 09:14:17 +0000 (11:14 +0200)
committerStefan Roese <sr@denx.de>
Sat, 31 Jul 2021 07:49:31 +0000 (09:49 +0200)
The 'buf' variable is a pointer and '_buf' is the array itself.
Therefore we should pass sizeof(_buf) instead of sizeof(buf) to read().

Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Stefan Roese <sr@denx.de>
Reviewed-by: Chris Packham <judge.packham@gmail.com>
Tested-by: Chris Packham <judge.packham@gmail.com>
tools/kwboot.c

index 2683e5360c25872c3a4e1c4c7728885093d80dbc..1ba5ded5d3899e80d4517658e2626839b85080e3 100644 (file)
@@ -465,7 +465,7 @@ kwboot_term_pipe(int in, int out, char *quit, int *s)
        ssize_t nin, nout;
        char _buf[128], *buf = _buf;
 
-       nin = read(in, buf, sizeof(buf));
+       nin = read(in, buf, sizeof(_buf));
        if (nin <= 0)
                return -1;