]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
video: Use 'int' for loop variables instead of short
authorSimon Glass <sjg@chromium.org>
Sat, 30 Jan 2016 22:45:16 +0000 (15:45 -0700)
committerAnatolij Gustschin <agust@denx.de>
Sat, 6 Feb 2016 12:55:49 +0000 (13:55 +0100)
Using short doesn't save anything and is confusing when the width and height
variables are ulong.

This may fix Coverity CID134902 but I doubt it.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
drivers/video/video_bmp.c

index c9075d62dd7622049b8d929bccb71303f81f21a3..fb7943e06d99698e379dbd2a8346c7d166302bc5 100644 (file)
@@ -194,7 +194,7 @@ int video_bmp_display(struct udevice *dev, ulong bmp_image, int x, int y,
 {
        struct video_priv *priv = dev_get_uclass_priv(dev);
        ushort *cmap_base = NULL;
-       ushort i, j;
+       int i, j;
        uchar *fb;
        struct bmp_image *bmp = map_sysmem(bmp_image, 0);
        uchar *bmap;