]> git.dujemihanovic.xyz Git - u-boot.git/commit
cros_ec: Handling EC_CMD_GET_NEXT_EVENT
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Mon, 9 Nov 2020 20:34:25 +0000 (21:34 +0100)
committerSimon Glass <sjg@chromium.org>
Sat, 14 Nov 2020 22:23:41 +0000 (15:23 -0700)
commita3e458524c15710e4ac9ce1556a5f0898084d09a
treec433f9abf09a77a11504670ccdb3dc6fbf3507bb
parent4cb862fe28332f187f636b37b48fb0fbaf3432ec
cros_ec: Handling EC_CMD_GET_NEXT_EVENT

With commit 690079767803 ("cros_ec: Support keyboard scanning with
EC_CMD_GET_NEXT_EVENT") check_for_keys() tries to read keyboard
strokes using EC_CMD_GET_NEXT_EVENT. But the sandbox driver does
not understand this command. We need to reply with
-EC_RES_INVALID_COMMAND to force check_for_keys() to fall back to
use EC_CMD_MKBP_STATE. Currently the driver prints

    ** Unknown EC command 0x67

in this case. With the patch the message is suppressed.

In a future patch we should upgrade the sandbox driver to provide
EC_CMD_GET_NEXT_EVENT support.

Fixes: 690079767803 ("cros_ec: Support keyboard scanning with EC_CMD_GET_NEXT_EVENT")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
drivers/misc/cros_ec_sandbox.c