]> git.dujemihanovic.xyz Git - u-boot.git/commit
board: sifive: Fix a potential build warning in board_fdt_blob_setup()
authorBin Meng <bmeng.cn@gmail.com>
Sat, 11 Sep 2021 14:31:23 +0000 (22:31 +0800)
committerLeo Yu-Chi Liang <ycliang@andestech.com>
Wed, 20 Oct 2021 02:59:00 +0000 (10:59 +0800)
commita0cfe137157243d9cfcc928e0939b3d65274b554
treef40823ec08d5554c287550f126880bede4ba7276
parentfb1018106a7bbb1a0d723029f6760b1b1b4d306d
board: sifive: Fix a potential build warning in board_fdt_blob_setup()

Commit 47d73ba4f4a4 ("board: sifive: overwrite board_fdt_blob_setup in u-boot proper")
added a board-specific implementation of board_fdt_blob_setup() which
takes a pointer as the return value, but it does not return anything
if CONFIG_OF_SEPARATE is not enabled. This will cause a build warning
seen when testing booting S-mode U-Boot directly from QEMU, per the
instructions in [1]:

  board/sifive/unleashed/unleashed.c: In function ‘board_fdt_blob_setup’:
  board/sifive/unleashed/unleashed.c:125:1: warning: control reaches end of non-void function [-Wreturn-type]

Return &_end as the default case.

[1] https://qemu.readthedocs.io/en/latest/system/riscv/sifive_u.html#running-u-boot

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
Reviewed-by: Rick Chen <rick@andestech.com>
board/sifive/unleashed/unleashed.c
board/sifive/unmatched/unmatched.c