]> git.dujemihanovic.xyz Git - u-boot.git/commit
usb: bootm: Drop old USB-device-removal code
authorSimon Glass <sjg@chromium.org>
Fri, 26 Jul 2024 12:36:09 +0000 (06:36 -0600)
committerTom Rini <trini@konsulko.com>
Wed, 31 Jul 2024 17:20:57 +0000 (11:20 -0600)
commit59ca3a2f20f37fd45e4ccf266ae2df9379c7af91
tree00a99b897f720b4c9279a0c9076fec109bfa722d
parentc502d7ada25ab21cc04e1df62fd22af5c8360275
usb: bootm: Drop old USB-device-removal code

USB is stopped using driver model now, in dm_remove_devices_flags() in
announce_and_cleanup() at the top of this file.

The usb_stop() call actually unbinds devices.

When a USB device is unbound, it causes any bootflows attached to it to
be removed, via a call to bootdev_clear_bootflows() from
bootdev_pre_unbind(). This obviously makes it impossible to boot the
bootflow.

However, when booting a bootflow that relies on USB, usb_stop() is
called, which unbinds the device. At that point any information
attached to the bootflow is dropped.

This is quite risky since the contents of freed memory are not
guaranteed to remain unchanged. Depending on what other options are
done before boot, a hard-to-find bug may crop up.

Drop the call to this old function.

Leave the netconsole call there, since this needs conversion to
driver model.

Signed-off-by: Simon Glass <sjg@chromium.org>
Suggested-by: Shantur Rathore <i@shantur.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
boot/bootm.c