]> git.dujemihanovic.xyz Git - u-boot.git/commit
ARM: tegra: fix USB ULPI PHY reset signal inversion confusion
authorStephen Warren <swarren@nvidia.com>
Thu, 15 Sep 2016 18:19:37 +0000 (12:19 -0600)
committerTom Warren <twarren@nvidia.com>
Tue, 27 Sep 2016 16:11:03 +0000 (09:11 -0700)
commit2f6a7e8ce5df8b99d84bfd486c6f99d92322ce04
treeeb77203c632945bc09e6991da1f4cbc37c782d9d
parentfc607d9ab96654973bd13dc0de1b2ff6d3d901b4
ARM: tegra: fix USB ULPI PHY reset signal inversion confusion

USB ULPI PHY reset signals are typically active low. Consequently, they
should be marked as GPIO_ACTIVE_LOW in device tree, and indeed they are in
the Linux kernel DTs, and in DT properties that U-Boot doesn't yet use.
However, in DT properties that U-Boot does use, the value has been set to
0 (== GPIO_ACTIVE_HIGH) to work around a bug in U-Boot.

This change fixes the DT to correctly represent the HW, and fixes the
Tegra USB driver to cope with the fact that dm_gpio_set_value() internally
handles any inversions implied by the DT value GPIO_ACTIVE_LOW.

Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Tom Warren <twarren@nvidia.com>
arch/arm/dts/tegra20-colibri.dts
arch/arm/dts/tegra20-harmony.dts
drivers/usb/host/ehci-tegra.c