]> git.dujemihanovic.xyz Git - u-boot.git/commit
serial, ns16550: bugfix: ns16550 fifo not enabled
authorHeiko Schocher <hs@denx.de>
Wed, 18 Jan 2017 07:05:49 +0000 (08:05 +0100)
committerTom Rini <trini@konsulko.com>
Fri, 20 Jan 2017 14:15:19 +0000 (09:15 -0500)
commit17fa032671f7981628fe16b30399638842a4b1bb
tree473870132e1d52495cf5e149aa914f69b7e59709
parent0675f992dbf4a785a05a1baf149c2bce6aa5fe90
serial, ns16550: bugfix: ns16550 fifo not enabled

commit: 65f83802b7a5b "serial: 16550: Add getfcr accessor"
breaks u-boot commandline working with long commands
sending to the board.

Since the above patch, you have to setup the fcr register.

For board/archs which enable OF_PLATDATA, the new field
fcr in struct ns16550_platdata is not filled with a
default value ...

This leads in not setting up the uarts fifo, which ends
in problems, when you send long commands to u-boots
commandline.

Detected this issue with automated tbot tests on am335x
based shc board.

The error does not popup, if you type commands. You need
to copy&paste a long command to u-boots commandshell
(or send a long command with tbot)

Possible boards/plattforms with problems:
./arch/arm/cpu/arm926ejs/lpc32xx/devices.c
./arch/arm/mach-tegra/board.c
./board/overo/overo.c
./board/quipos/cairo/cairo.c
./board/logicpd/omap3som/omap3logic.c
./board/logicpd/zoom1/zoom1.c
./board/timll/devkit8000/devkit8000.c
./board/lg/sniper/sniper.c
./board/ti/beagle/beagle.c
./drivers/serial/serial_rockchip.c

Signed-off-by: Heiko Schocher <hs@denx.de>
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
Tested-by: Adam Ford <aford173@gmail.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
14 files changed:
arch/arm/cpu/arm926ejs/lpc32xx/devices.c
arch/arm/mach-omap2/am33xx/board.c
arch/arm/mach-tegra/board.c
board/isee/igep00x0/igep00x0.c
board/lg/sniper/sniper.c
board/logicpd/omap3som/omap3logic.c
board/logicpd/zoom1/zoom1.c
board/overo/overo.c
board/quipos/cairo/cairo.c
board/ti/beagle/beagle.c
board/timll/devkit8000/devkit8000.c
drivers/serial/ns16550.c
drivers/serial/serial_rockchip.c
include/ns16550.h