]> git.dujemihanovic.xyz Git - u-boot.git/commit
do_smhload: fix return code
authorRyan Harkin <ryan.harkin@linaro.org>
Thu, 2 Mar 2017 17:45:16 +0000 (17:45 +0000)
committerTom Rini <trini@konsulko.com>
Fri, 10 Mar 2017 00:52:14 +0000 (19:52 -0500)
commit072c8c4cedad87c4be4edca259e1760d7db42e1b
tree587431b2c9f407bb892d8c8b07049318abad2815
parent285226785ee178c0bbe8a67185c21e461cf4bc9f
do_smhload: fix return code

do_smhload was using a ulong to store the return value from
smh_load_file. That returns an int, where -1 indicates an error. As a
ulong will never be negative, smh_load_file errors were not detected and
so_smhload always returned zero.

Also, when errors were spotted, do_smhload was returning 1, rather than
the enumeration CMD_RET_FAILURE (which is also 1).

Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
arch/arm/lib/semihosting.c