]> git.dujemihanovic.xyz Git - u-boot.git/commit
usb: dwc3-meson-gxl: force mode on child add/removal
authorNeil Armstrong <neil.armstrong@linaro.org>
Tue, 17 Jan 2023 09:11:45 +0000 (10:11 +0100)
committerNeil Armstrong <neil.armstrong@linaro.org>
Fri, 20 Jan 2023 15:21:31 +0000 (16:21 +0100)
commit043a9674b64741e02b99e9c5ad2e4ee5a1c841d5
treeb8450f8e2d5d868c90a5c29417d40196cb2df254
parentb96640cbfb319071aea7915cfa2f7aefe08bbc08
usb: dwc3-meson-gxl: force mode on child add/removal

arch/mach-meson has some custom usb logic, in particular:
* on board_usb_init(), we force USB_DR_MODE_PERIPHERAL
* on board_usb_cleanup(), we force USB_DR_MODE_HOST

With DM_USB_GADGET=y, board_usb_init/cleanup() are no
longer used when we call usb_gadget_initialize().
Instead, the generic (from udc-uclass) initialization/release is
called, which itself calls the controller driver's probe()/remove().

Therefore, enabling DM_USB_GADGET=y will mean that this mode
switching will break.

To prepare for enabling DM_USB_GADGET, perform the mode switching
when the "amlogic,meson-g12a-usb" (dwc2) driver is
probed()/removed() instead.

This is achieved via the glue driver, which gets notified each time one
of its children is probed()/removed.

Note: this change should be harmless without DM_USB_GADGET=y
because the amlogic-g12a-usb driver is not probed via driver model.

Thanks for Mattijs for the original work at [1].

[1] https://lore.kernel.org/all/20221024-meson-dm-usb-v1-1-2ab077a503b9@baylibre.com/

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Reviewed-by: Marek Vasut <marex@denx.de>
Link: https://lore.kernel.org/r/20230117-u-boot-usb-gxl-otg-dm-v1-1-2853f6d75b06@linaro.org
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
drivers/usb/dwc3/dwc3-meson-gxl.c