]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
usb: Add missing guard around env_get() in usb_hub
authorMarek Vasut <marex@denx.de>
Mon, 19 Sep 2022 19:19:23 +0000 (21:19 +0200)
committerMarek Vasut <marex@denx.de>
Mon, 10 Oct 2022 16:08:18 +0000 (18:08 +0200)
The env_get() might be undefined in case ENV_SUPPORT is disabled,
which may happen e.g. in SPL. Add missing ifdef guard around the
env_get() to prevent build failure.

Signed-off-by: Marek Vasut <marex@denx.de>
Tested-by: Fabio Estevam <festevam@denx.de>
common/usb_hub.c

index d73638950b9eed0ba8e239702aec75c9cf09a74d..95f1449b5cb44ca15680a905b49d77c17147a6af 100644 (file)
@@ -168,7 +168,7 @@ static void usb_hub_power_on(struct usb_hub_device *hub)
        int i;
        struct usb_device *dev;
        unsigned pgood_delay = hub->desc.bPwrOn2PwrGood * 2;
-       const char *env;
+       const char __maybe_unused *env;
 
        dev = hub->pusb_dev;
 
@@ -193,10 +193,12 @@ static void usb_hub_power_on(struct usb_hub_device *hub)
         * but allow this time to be increased via env variable as some
         * devices break the spec and require longer warm-up times
         */
+#if CONFIG_IS_ENABLED(ENV_SUPPORT)
        env = env_get("usb_pgood_delay");
        if (env)
                pgood_delay = max(pgood_delay,
                                  (unsigned)simple_strtol(env, NULL, 0));
+#endif
        debug("pgood_delay=%dms\n", pgood_delay);
 
        /*