]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
net: dm: Remove warning about EEPROM provided MAC address
authorAndre Przywara <andre.przywara@arm.com>
Thu, 11 Jun 2020 11:03:16 +0000 (12:03 +0100)
committerTom Rini <trini@konsulko.com>
Tue, 7 Jul 2020 22:23:48 +0000 (18:23 -0400)
Similar to patch 821fec0ceb3e ("net: remove scary warning about EEPROM
provided MAC address") this removes the somewhat awkward "warning" on
boards using DM_ETH:
In many parts of the computing world having a unique MAC address
sitting in some on-NIC storage is considered the normal case.

If there is a properly provided MAC address (either from ROM or from DT),
remove the warning to not scare the user unnecessarily.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-By: Ramon Fried <rfried.dev@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
net/eth-uclass.c

index 7f89f65c92a3ad4ac1bcc61b23044c050631b205..0d9b75a9a20a1e4fab1bc268471e257952b65a16 100644 (file)
@@ -560,8 +560,6 @@ static int eth_post_probe(struct udevice *dev)
                memcpy(pdata->enetaddr, env_enetaddr, ARP_HLEN);
        } else if (is_valid_ethaddr(pdata->enetaddr)) {
                eth_env_set_enetaddr_by_index("eth", dev->seq, pdata->enetaddr);
-               printf("\nWarning: %s using MAC address from %s\n",
-                      dev->name, source);
        } else if (is_zero_ethaddr(pdata->enetaddr) ||
                   !is_valid_ethaddr(pdata->enetaddr)) {
 #ifdef CONFIG_NET_RANDOM_ETHADDR