]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
usb: xhci: xhci_bulk_tx: Don't "BUG" when comparing addresses
authorStefan Roese <sr@denx.de>
Mon, 24 Aug 2020 11:04:37 +0000 (13:04 +0200)
committerDaniel Schwierzeck <daniel.schwierzeck@gmail.com>
Wed, 7 Oct 2020 18:25:57 +0000 (20:25 +0200)
Octeon uses mapped addresses for virtual and physical memory. It's not
that easy to calculate the resulting addresses here. So let's remove
this BUG_ON() completely, as it's not really helpful.

Please also note, that BUG_ON() is not recommended any more in the Linux
kernel.

Signed-off-by: Stefan Roese <sr@denx.de>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Cc: Bin Meng <bmeng.cn@gmail.com>
Cc: Marek Vasut <marex@denx.de>
drivers/usb/host/xhci-ring.c

index b118207d937b8cee557e4511cbeb5fda0b7b3ec3..13065d7ca99c3fb63d914695e19ad91caf25dba7 100644 (file)
@@ -722,8 +722,6 @@ int xhci_bulk_tx(struct usb_device *udev, unsigned long pipe,
 
        BUG_ON(TRB_TO_SLOT_ID(field) != slot_id);
        BUG_ON(TRB_TO_EP_INDEX(field) != ep_index);
-       BUG_ON(*(void **)(uintptr_t)le64_to_cpu(event->trans_event.buffer) -
-               buffer > (size_t)length);
 
        record_transfer_result(udev, event, length);
        xhci_acknowledge_event(ctrl);