xilinx: common: Fix static checker warnings

Avoid signed extension for uuid and byte.

Eliminate the below smatch warnings:
board/xilinx/common/board.c:128 xilinx_eeprom_legacy_cleanup()
warn: impossible condition '(byte == 255) => ((-128)-127 == 255)'

board/xilinx/common/board.c:466 board_late_init_xilinx()
warn: argument 3 to %02x specifier has type 'char'
board/xilinx/common/board.c:466 board_late_init_xilinx()
warn: argument 4 to %02x specifier has type 'char'

Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
Link: https://lore.kernel.org/r/20220926065242.4355-1-venkatesh.abbarapu@amd.com
Signed-off-by: Michal Simek <michal.simek@amd.com>

diff --git a/board/xilinx/common/board.c b/board/xilinx/common/board.c
index 391ce4dbd720cc469d316a7bc3d8d31401918bbc..bbfe84b8d0a12d5f10ff2937ca8332aa35944782 100644 (file)
--- a/board/xilinx/common/board.c
+++ b/board/xilinx/common/board.c
@@ -121,7 +121,7 @@ struct xilinx_legacy_format {
 static void xilinx_eeprom_legacy_cleanup(char *eeprom, int size)
 {
        int i;
-       char byte;
+       unsigned char byte;
 
        for (i = 0; i < size; i++) {
                byte = eeprom[i];
@@ -460,8 +460,8 @@ int board_late_init_xilinx(void)
                                                        desc->serial);
 
                        if (desc->uuid[0]) {
-                               char uuid[UUID_STR_LEN + 1];
-                               char *t = desc->uuid;
+                               unsigned char uuid[UUID_STR_LEN + 1];
+                               unsigned char *t = desc->uuid;
 
                                memset(uuid, 0, UUID_STR_LEN + 1);