]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
arm: stm32mp: stm32prog: check result of find_mmc_device
authorPatrick Delaunay <patrick.delaunay@st.com>
Mon, 6 Jul 2020 11:20:58 +0000 (13:20 +0200)
committerPatrice Chotard <patrice.chotard@st.com>
Tue, 28 Jul 2020 15:43:46 +0000 (17:43 +0200)
Check result of find_mmc_device() before calling mmc_init().

This patch avoid a data abort when the command try to acces
to sd/mmc device deactivated in device tree.

Fixes: aff4c5dd8265 ("stm32mp: stm32prog: add MMC device")
Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
Reviewed-by: Patrice Chotard <patrice.chotard@st.com>
arch/arm/mach-stm32mp/cmd_stm32prog/stm32prog.c

index c5b8841b23c0944719c23eb93c0be3d199ab73b2..e4199dbaa59862c5c62fc15544701da38af76b30 100644 (file)
@@ -560,7 +560,7 @@ static int init_device(struct stm32prog_data *data,
 #ifdef CONFIG_MMC
        case STM32PROG_MMC:
                mmc = find_mmc_device(dev->dev_id);
-               if (mmc_init(mmc)) {
+               if (!mmc || mmc_init(mmc)) {
                        stm32prog_err("mmc device %d not found", dev->dev_id);
                        return -ENODEV;
                }