mmc: zynq_sdhci: Fix timeout issue

In the workaround added with 'commit b6f44082d5cd ("mmc: zynq_sdhci: Wait
till sd card detect state is stable")' the timeout variable has post
decrement. Whenever timeout happens, this post decrement is making
timeout=0xffffffff, so timeout error print and return statement are
never reached. Fix it by decrementing it inside the while loop.

Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Link: https://lore.kernel.org/r/61fc1160ada0dd622cd29e381a74af7bf3d9a200.1645625609.git.michal.simek@xilinx.com

diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc/zynq_sdhci.c
index 5cea4c695e8d88cab7cf79c232bccc07de8351a7..f4d69a2f709874adfec7008788b606fd94f00450 100644 (file)
--- a/drivers/mmc/zynq_sdhci.c
+++ b/drivers/mmc/zynq_sdhci.c
@@ -773,8 +773,9 @@ static int arasan_sdhci_probe(struct udevice *dev)
                u32 timeout = 1000;
 
                while (((sdhci_readl(host, SDHCI_PRESENT_STATE) &
-                        SDHCI_CARD_STATE_STABLE) == 0) && timeout--) {
+                        SDHCI_CARD_STATE_STABLE) == 0) && timeout) {
                        mdelay(1);
+                       timeout--;
                }
                if (!timeout) {
                        dev_err(dev, "Sdhci card detect state not stable\n");