]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
mtd: mtdpart: Change size type from fdt_addr_t to fdt_size_t
authorPali Rohár <pali@kernel.org>
Fri, 13 May 2022 20:24:51 +0000 (22:24 +0200)
committerTom Rini <trini@konsulko.com>
Mon, 6 Jun 2022 21:47:17 +0000 (17:47 -0400)
Set correct type for 3rd argument of ofnode_get_addr_size_index_notrans()
function. It expects fdt_size_t * and not fdt_addr_t *.

When these two types do not have same size then U-Boot throw compile
warning:

    drivers/mtd/mtdpart.c: In function ‘add_mtd_partitions_of’:
    drivers/mtd/mtdpart.c:906:57: warning: passing argument 3 of ‘ofnode_get_addr_size_index_notrans’ from incompatible pointer type [-Wincompatible-pointer-types]
       offset = ofnode_get_addr_size_index_notrans(child, 0, &size);
                                                             ^~~~~
    In file included from include/dm/device.h:13,
                     from include/linux/mtd/mtd.h:26,
                     from include/ubi_uboot.h:28,
                     from drivers/mtd/mtdpart.c:27:
    include/dm/ofnode.h:530:25: note: expected ‘fdt_size_t *’ {aka ‘long long unsigned int *’} but argument is of type ‘fdt_addr_t *’ {aka ‘long unsigned int *’}
                 fdt_size_t *size);
                 ~~~~~~~~~~~~^~~~

Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Marek Behún <marek.behun@nic.cz>
drivers/mtd/mtdpart.c

index d077897e4a757b847bd65e2b38fc1a43a93fb76e..56aa58b58bb7f62d9d166e6bf81342d8cc300839 100644 (file)
@@ -902,7 +902,8 @@ int add_mtd_partitions_of(struct mtd_info *master)
        ofnode_for_each_subnode(child, parts) {
                struct mtd_partition part = { 0 };
                struct mtd_info *slave;
-               fdt_addr_t offset, size;
+               fdt_addr_t offset;
+               fdt_size_t size;
 
                if (!ofnode_is_available(child))
                        continue;