]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
rockchip: rk3399: spl: always report errors triggering a hard stop
authorPhilipp Tomsich <philipp.tomsich@theobroma-systems.com>
Mon, 19 Nov 2018 12:03:51 +0000 (13:03 +0100)
committerPhilipp Tomsich <philipp.tomsich@theobroma-systems.com>
Fri, 30 Nov 2018 18:03:16 +0000 (19:03 +0100)
The RK3399 SPL has two cases that may end in a hard-stop: if either
the pinctrl can not be initialised or if the DRAM fails to initialise.
Both have previously not triggered an error message unless DEBUG was
defined (i.e. both used debug() to print the error).

This converts both error messages to be printed using pr_err() to
ensure that some output points to the cause of the hard-stop.

Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
arch/arm/mach-rockchip/rk3399-board-spl.c

index 43350e38b13c1eca3030e3b425bcbc4540357177..0198c6c65f4e3e3852b64abaa6ff1f3e2afea380 100644 (file)
@@ -202,13 +202,13 @@ void board_init_f(ulong dummy)
 
        ret = uclass_get_device(UCLASS_PINCTRL, 0, &pinctrl);
        if (ret) {
-               debug("Pinctrl init failed: %d\n", ret);
+               pr_err("Pinctrl init failed: %d\n", ret);
                return;
        }
 
        ret = uclass_get_device(UCLASS_RAM, 0, &dev);
        if (ret) {
-               debug("DRAM init failed: %d\n", ret);
+               pr_err("DRAM init failed: %d\n", ret);
                return;
        }
 }