]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
common: eeprom_field: Drop unnecessary comparison
authorMarek Behún <kabel@kernel.org>
Tue, 21 May 2024 07:13:28 +0000 (09:13 +0200)
committerTom Rini <trini@konsulko.com>
Fri, 7 Jun 2024 16:47:59 +0000 (10:47 -0600)
The byte variable is of type unsigned char, it is never less than zero.
The error case is handled by *endptr, so drop the comparison altogether.

Signed-off-by: Marek Behún <kabel@kernel.org>
common/eeprom/eeprom_field.c

index 9b831414a4ba146f8ad469b212d2994757b6adc4..26f6041e54883a4dec931e6105c4bd2c1e151db9 100644 (file)
@@ -56,7 +56,7 @@ static int __eeprom_field_update_bin(struct eeprom_field *field,
                }
 
                byte = simple_strtoul(tmp, &endptr, 16);
-               if (*endptr != '\0' || byte < 0)
+               if (*endptr != '\0')
                        return -1;
 
                field->buf[j] = byte;