]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
i2c: stm32: fix comment and remove unused AUTOEND bit
authorAlain Volmat <alain.volmat@foss.st.com>
Mon, 12 Sep 2022 08:41:58 +0000 (10:41 +0200)
committerPatrick Delaunay <patrick.delaunay@foss.st.com>
Thu, 15 Sep 2022 12:58:52 +0000 (14:58 +0200)
Comment within stm32_i2c_message_start is misleading, indicating
that AUTOEND bit is setted while it is actually cleared.
Moreover, the bit is actually never setted so there is no need
to clear it hence get rid of this bit clear and the bit macro
as well.

Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Reviewed-by: Heiko Schocher <hs@denx.de>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
drivers/i2c/stm32f7_i2c.c

index 3a727e68acca74a5eeafc7f8b918d6dce4de75d8..e3b4991eb89cd19f9e6049b41b4fa67cdd6c480a 100644 (file)
@@ -57,7 +57,6 @@ struct stm32_i2c_regs {
 #define STM32_I2C_CR1_PE                       BIT(0)
 
 /* STM32 I2C control 2 */
-#define STM32_I2C_CR2_AUTOEND                  BIT(25)
 #define STM32_I2C_CR2_RELOAD                   BIT(24)
 #define STM32_I2C_CR2_NBYTES_MASK              GENMASK(23, 16)
 #define STM32_I2C_CR2_NBYTES(n)                        ((n & 0xff) << 16)
@@ -304,9 +303,8 @@ static void stm32_i2c_message_start(struct stm32_i2c_priv *i2c_priv,
                cr2 |= STM32_I2C_CR2_SADD7(msg->addr);
        }
 
-       /* Set nb bytes to transfer and reload or autoend bits */
-       cr2 &= ~(STM32_I2C_CR2_NBYTES_MASK | STM32_I2C_CR2_RELOAD |
-                STM32_I2C_CR2_AUTOEND);
+       /* Set nb bytes to transfer and reload (if needed) */
+       cr2 &= ~(STM32_I2C_CR2_NBYTES_MASK | STM32_I2C_CR2_RELOAD);
        if (msg->len > STM32_I2C_MAX_LEN) {
                cr2 |= STM32_I2C_CR2_NBYTES(STM32_I2C_MAX_LEN);
                cr2 |= STM32_I2C_CR2_RELOAD;