firmware: scmi: mailbox transport: fix probe failure implementation

Correct scmi mailbox probe function that can't free the scmi channel
instance since its auto-allocated by the device model framework.

Cc: Simon Glass <sjg@chromium.org>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

diff --git a/drivers/firmware/scmi/mailbox_agent.c b/drivers/firmware/scmi/mailbox_agent.c
index ea35e7e09edcbd1b18374af042169222cd41188a..eb841d692b3460d5eaabf003ff33ef56d97f1731 100644 (file)
--- a/drivers/firmware/scmi/mailbox_agent.c
+++ b/drivers/firmware/scmi/mailbox_agent.c
@@ -72,17 +72,13 @@ int scmi_mbox_probe(struct udevice *dev)
        ret = mbox_get_by_index(dev, 0, &chan->mbox);
        if (ret) {
                dev_err(dev, "Failed to find mailbox: %d\n", ret);
-               goto out;
+               return ret;
        }
 
        ret = scmi_dt_get_smt_buffer(dev, &chan->smt);
        if (ret)
                dev_err(dev, "Failed to get shm resources: %d\n", ret);
 
-out:
-       if (ret)
-               devm_kfree(dev, chan);
-
        return ret;
 }