]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
efi_loader: check lowest supported version
authorMasahisa Kojima <masahisa.kojima@linaro.org>
Wed, 7 Jun 2023 05:41:55 +0000 (14:41 +0900)
committerHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Thu, 8 Jun 2023 07:20:36 +0000 (09:20 +0200)
The FMP Payload Header which EDK II capsule generation scripts
insert has a firmware version.
This commit reads the lowest supported version stored in the
device tree, then check if the firmware version in FMP payload header
of the ongoing capsule is equal or greater than the
lowest supported version. If the firmware version is lower than
lowest supported version, capsule update will not be performed.

Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
lib/efi_loader/efi_firmware.c

index ae631f49f7e2ca83755b656458f33b1c0b914f66..b557738370eb6caae6afb3c86b51e3dd1f4f689f 100644 (file)
@@ -419,7 +419,8 @@ static void efi_firmware_get_fw_version(const void **p_image,
  * @image_index:       Image index
  * @state:             Pointer to fmp state
  *
- * Verify the capsule file
+ * Verify the capsule authentication and check if the fw_version
+ * is equal or greater than the lowest supported version.
  *
  * Return:             status code
  */
@@ -429,11 +430,27 @@ efi_status_t efi_firmware_verify_image(const void **p_image,
                                       u8 image_index,
                                       struct fmp_state *state)
 {
+       u32 lsv;
        efi_status_t ret;
+       efi_guid_t *image_type_id;
 
        ret = efi_firmware_capsule_authenticate(p_image, p_image_size);
+       if (ret != EFI_SUCCESS)
+               return ret;
+
        efi_firmware_get_fw_version(p_image, p_image_size, state);
 
+       image_type_id = efi_firmware_get_image_type_id(image_index);
+       if (!image_type_id)
+               return EFI_INVALID_PARAMETER;
+
+       efi_firmware_get_lsv_from_dtb(image_index, image_type_id, &lsv);
+       if (state->fw_version < lsv) {
+               log_err("Firmware version %u too low. Expecting >= %u. Aborting update\n",
+                       state->fw_version, lsv);
+               return EFI_INVALID_PARAMETER;
+       }
+
        return ret;
 }