]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
tegra: mmc: Set the bus width correctly
authorSimon Glass <sjg@chromium.org>
Thu, 8 Jun 2017 03:11:48 +0000 (21:11 -0600)
committerTom Warren <twarren@nvidia.com>
Tue, 20 Jun 2017 16:47:59 +0000 (09:47 -0700)
The driver currently does not reset bit 5 of the hostctl register even if
the MMC stack requests it. Then means that once a bus width of 8 is
selected it is not possible to change it back to 1. This breaks
'mmc rescan' which needs to start off with a bus width of 1.

The problem was surfaced by enabling CONFIG_DM_MMC_OPS on tegra. Without
this option the MMC stack fully reinits the driver on a 'mmc rescan'.
But with this option driver model does not re-probe a driver once it has
been probed once.

Fix the driver to honour the request.

Signed-off-by: Simon Glass <sjg@chromium.org>
Tested-by: Peter Chubb <peter.chubb@data61.csiro.au>
Tested-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Tom Warren <twarren@nvidia.com>
drivers/mmc/tegra_mmc.c

index 338e42b52833f6fb7e4e8e8e60de9a9cbd3e4e16..7d945a172e8a641c68bcf386c7ad2ab0a6eb8f21 100644 (file)
@@ -438,7 +438,7 @@ static int tegra_mmc_set_ios(struct udevice *dev)
        else if (mmc->bus_width == 4)
                ctrl |= (1 << 1);
        else
-               ctrl &= ~(1 << 1);
+               ctrl &= ~(1 << 1 | 1 << 5);
 
        writeb(ctrl, &priv->reg->hostctl);
        debug("mmc_set_ios: hostctl = %08X\n", ctrl);