]> git.dujemihanovic.xyz Git - u-boot.git/commit
common/board_r.c: drop legacy and unused bi_enetaddr
authorRasmus Villemoes <rasmus.villemoes@prevas.dk>
Fri, 20 May 2022 11:19:08 +0000 (13:19 +0200)
committerTom Rini <trini@konsulko.com>
Mon, 6 Jun 2022 22:01:21 +0000 (18:01 -0400)
commite5e04eaa2f1cb4dc37a12551018a00a18cab19de
tree40cc7f350c8cf3f335098fe2f169176dfbecd5d8
parentba9aa40bb387385b8ef8b6594661a97ddcb8d04c
common/board_r.c: drop legacy and unused bi_enetaddr

The bi_enetaddr field in struct bd_info is write-only; nothing ever
reads back the value.

Moreover, the value we write is more or less random, and certainly not
something one can rely on: If the board has a writable environment and
the mac address has been stored there, we fetch that value. But if the
board doesn't, this code runs before initr_net() -> eth_initialize(),
and thus before the code in eth-uclass which fetches MAC addresses
from eeprom, fuses or whatnot and populates the (run-time) environment
with those values.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Reviewed-by: Tom Rini <trini@konsulko.com>
common/board_r.c
include/asm-generic/u-boot.h