]> git.dujemihanovic.xyz Git - u-boot.git/commit
projects / u-boot.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: da0227f) | patch
omap3: incorrect logical check in do_emif4_init
authorxypron.glpk@gmx.de <xypron.glpk@gmx.de>
Sat, 15 Apr 2017 14:11:12 +0000 (16:11 +0200)
committerTom Rini <trini@konsulko.com>
Sat, 12 Aug 2017 23:17:20 +0000 (19:17 -0400)
commitb730ff3fd65c8d1c33f1c05ca3fbab579a86abb4
treedfff16d78d38ee0d4e66fab6b4ea85790c57c4fatree | snapshot
parentda0227f7d2568c0cb0e435ed3caf780f9846d9a0commit | diff
omap3: incorrect logical check in do_emif4_init

((readl(&emif4_base->sdram_iodft_tlgc) & (1<<10)) == 0x01)
is always false.
This does not match the comment
/*Wait till that bit clears*/

The problem was indicated by cppcheck.

I do not have the hardware to test if the code change below
leads to a correct system behavior.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
arch/arm/mach-omap2/omap3/emif4.c diff | blob | history
My U-Boot fork