]> git.dujemihanovic.xyz Git - u-boot.git/commit
regulator: rk8xx: fix incorrect device used for _ldo_[sg]et_suspend_value
authorQuentin Schulz <quentin.schulz@cherry.de>
Wed, 5 Jun 2024 09:33:21 +0000 (11:33 +0200)
committerKever Yang <kever.yang@rock-chips.com>
Fri, 14 Jun 2024 09:02:07 +0000 (17:02 +0800)
commit7bc5c3ea62471bca435a6365cd7c070653b3a794
treed828867e59e7c4f591e14854e0086655e9d205c7
parent53ce821586fcc66fc9a049dff5d15d9679905336
regulator: rk8xx: fix incorrect device used for _ldo_[sg]et_suspend_value

_ldo_get_suspend_value and _ldo_set_suspend_value get passed the parent
of the regulator (so the pmic) as first argument, therefore this udevice
should be used for pmic_* callbacks instead of using the parent of the
pmic.

To avoid further confusion, let's rename the argument to pmic instead of
dev, highlighting which kind of device we expect as argument.

Fixes: f047e4ab9762 ("regulator: rk8xx: add indirection level for some ldo callbacks")
Reported-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org> # chromebook-bob
drivers/power/regulator/rk8xx.c