]> git.dujemihanovic.xyz Git - u-boot.git/commit
spi: ti_qspi: Fix "spi-max-frequency" error path in ti_qspi_ofdata_to_platdata
authorOvidiu Panait <ovidiu.panait@windriver.com>
Sat, 28 Nov 2020 08:11:28 +0000 (10:11 +0200)
committerLokesh Vutla <lokeshvutla@ti.com>
Tue, 12 Jan 2021 04:51:41 +0000 (10:21 +0530)
commit705082d4b1a2040c9f1ff2a7d5c4f2fccafde4bc
treeb53015f2ef2528e68b89b1ba0494aff30ab789ff
parent49b4c54bc969aae9a79e598266feec3d74275635
spi: ti_qspi: Fix "spi-max-frequency" error path in ti_qspi_ofdata_to_platdata

struct ti_qspi_priv->max_hz is declared as unsigned int, so the following
error path check will always be false, even when "spi-max-frequency"
property is invalid/missing:
  priv->max_hz = fdtdec_get_int(blob, node, "spi-max-frequency", -1);
  if (priv->max_hz < 0) {
    ...
  }

Replace the fdtdec call with dev_read_u32_default() and use 0 as the
default value. Error out if max_hz is zero.

Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
drivers/spi/ti_qspi.c