]> git.dujemihanovic.xyz Git - u-boot.git/commit
net: phy: Make phy_interface_is_rgmii a switch statement
authorNishanth Menon <nm@ti.com>
Fri, 14 Apr 2023 22:06:45 +0000 (17:06 -0500)
committerTom Rini <trini@konsulko.com>
Fri, 5 May 2023 21:48:44 +0000 (17:48 -0400)
commit09005c2fb288decb4010f062fdc87d0b82e57584
tree373d329312ff9f0ae57c04fbe594818c74297a5d
parentf1a63f7181784e6de92a9759e7d61e5ce9c00582
net: phy: Make phy_interface_is_rgmii a switch statement

Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes
with Linux") reordered the enum definitions. This exposed a problem
in range checking functions to identify the interface type. Though
this specific api wasn't impacted (all the RGMII definitions remained
within range), this experience should be used to never to have to face
this kind of challenge again.

While it is possible for the phy drivers to use the enums directly,
drivers such as dp83867, dp83869, marvell, micrel_ksz90x1 etc use this
api.

Reported-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Reviewed-by: Marek BehĂșn <kabel@kernel.org>
Signed-off-by: Nishanth Menon <nm@ti.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
include/phy.h