]> git.dujemihanovic.xyz Git - u-boot.git/commit
mtd: spinand: Do not erase the block before writing a bad block marker
authorFrieder Schrempf <frieder.schrempf@kontron.de>
Mon, 22 Jun 2020 13:16:33 +0000 (16:16 +0300)
committerJagan Teki <jagan@amarulasolutions.com>
Fri, 18 Dec 2020 10:46:36 +0000 (16:16 +0530)
commit031b89e51b0fde5aabc258c2eb9c3f913f375f65
treeeaf6c4b9717b85c0f9cda80d6d4bac8d9bf8769f
parente6108004e66b7f0a8a2b9109d339558a1043b7de
mtd: spinand: Do not erase the block before writing a bad block marker

Currently when marking a block, we use spinand_erase_op() to erase
the block before writing the marker to the OOB area. Doing so without
waiting for the operation to finish can lead to the marking failing
silently and no bad block marker being written to the flash.

In fact we don't need to do an erase at all before writing the BBM.
The ECC is disabled for raw accesses to the OOB data and we don't
need to work around any issues with chips reporting ECC errors as it
is known to be the case for raw NAND.

Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")
Cc: stable@vger.kernel.org
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200218100432.32433-4-frieder.schrempf@kontron.de
drivers/mtd/nand/spi/core.c