From 14f66d65a33f622b8138ab0fcd1e18060a2355c2 Mon Sep 17 00:00:00 2001 From: Tang Yuantian <Yuantian.Tang@freescale.com> Date: Wed, 6 May 2015 11:21:33 +0800 Subject: [PATCH] fsl/sata: Replace sprintf() with snprintf() Function 'sprintf' does not check buffer boundaries but outputs to the buffer of fixed size which could potentially cause buffer overflow. Use a safer function to replace it. Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com> --- drivers/block/fsl_sata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/fsl_sata.c b/drivers/block/fsl_sata.c index 71d7cec7bd..735708aa20 100644 --- a/drivers/block/fsl_sata.c +++ b/drivers/block/fsl_sata.c @@ -113,7 +113,7 @@ int init_sata(int dev) /* Save the private struct to block device struct */ sata_dev_desc[dev].priv = (void *)sata; - sprintf(sata->name, "SATA%d", dev); + snprintf(sata->name, 12, "SATA%d", dev); /* Set the controller register base address to device struct */ reg = (fsl_sata_reg_t *)(fsl_sata_info[dev].sata_reg_base); -- 2.39.5