From: Ashok Reddy Soma Date: Wed, 23 Feb 2022 14:00:58 +0000 (+0100) Subject: xilinx: common: Optimise updating ethaddr from eeprom X-Git-Url: http://git.dujemihanovic.xyz/img/static/git-favicon.png?a=commitdiff_plain;h=ff8ee707fb0b5aab49832dd124a3c8cc9b3e5d41;p=u-boot.git xilinx: common: Optimise updating ethaddr from eeprom In board_late_init_xilinx() eth*addr are updated from the values read from eeprom. Ideally the MAC addresses are updated sequencially. So if any MAC address is invalid, it means there are no further valid values. So optimise this logic by replacing continue with break. Signed-off-by: Ashok Reddy Soma Signed-off-by: Michal Simek Link: https://lore.kernel.org/r/efef0d07add5d5777396ea111ad75411dc402db3.1645624855.git.michal.simek@xilinx.com --- diff --git a/board/xilinx/common/board.c b/board/xilinx/common/board.c index 0068cb8792..db089c4a0b 100644 --- a/board/xilinx/common/board.c +++ b/board/xilinx/common/board.c @@ -416,7 +416,7 @@ int board_late_init_xilinx(void) for (i = 0; i < EEPROM_HDR_NO_OF_MAC_ADDR; i++) { if (!desc->mac_addr[i]) - continue; + break; if (is_valid_ethaddr((const u8 *)desc->mac_addr[i])) ret |= eth_env_set_enetaddr_by_index("eth",